-
Notifications
You must be signed in to change notification settings - Fork 171
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## develop #1912 +/- ##
============================================
+ Coverage 22.66% 59.61% +36.94%
============================================
Files 450 511 +61
Lines 20541 21197 +656
Branches 5273 5714 +441
============================================
+ Hits 4656 12636 +7980
+ Misses 15884 8539 -7345
- Partials 1 22 +21
Continue to review full report at Codecov.
|
throw new Error( | ||
"Your previous transaction hasn't been processed yet. Please wait a moment then check the transaction history before trying again." | ||
); | ||
} | ||
|
||
if (e.message.includes("was not confirmed in")) { | ||
throw new Error( | ||
"Your transaction may have failed. Please wait a moment then check the transaction history before trying again." | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not certain this works on frontends (LLD & LLM), the text may not be displayed. Even so, it would not be translated.
The way to do it is to just throw specialized errors, that you can add in src/families/solana/errors.ts
and on the UI side you can define the english wording for these errors:
- LLD: https://github.com/LedgerHQ/ledger-live-desktop/blob/ee7a655afc31964d033b2c2cbc74fb395f34891e/static/i18n/en/app.json#L3722
- LLM: https://github.com/LedgerHQ/ledger-live-mobile/blob/686fc8301353ff10dcefc047bacae7f218beb923/src/locales/en/common.json#L85
then we have translation teams that will be able to translate them to every supported language.
Context (issues, jira)