Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Solana integration 4 #1912

Merged
22 commits merged into from
May 9, 2022
Merged

Solana integration 4 #1912

22 commits merged into from
May 9, 2022

Conversation

konoart
Copy link
Contributor

@konoart konoart commented Apr 26, 2022

Context (issues, jira)

  • Add fixes discussed with the team after initial release of solana staking.
  • Update deps.

@konoart konoart requested a review from a team as a code owner April 26, 2022 07:38
@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) May 5, 2022 at 11:33AM (UTC)

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1912 (459b1dd) into develop (49e8169) will increase coverage by 36.94%.
The diff coverage is 62.50%.

❗ Current head 459b1dd differs from pull request most recent head 022d8ef. Consider uploading reports for the commit 022d8ef to get more accurate results

@@             Coverage Diff              @@
##           develop    #1912       +/-   ##
============================================
+ Coverage    22.66%   59.61%   +36.94%     
============================================
  Files          450      511       +61     
  Lines        20541    21197      +656     
  Branches      5273     5714      +441     
============================================
+ Hits          4656    12636     +7980     
+ Misses       15884     8539     -7345     
- Partials         1       22       +21     
Impacted Files Coverage Δ
src/env.ts 65.21% <ø> (-17.40%) ⬇️
src/families/solana/js-signOperation.ts 8.57% <0.00%> (-0.43%) ⬇️
src/families/solana/bridge/mock.ts 29.62% <7.69%> (-3.71%) ⬇️
src/families/solana/js-broadcast.ts 17.64% <7.69%> (-10.93%) ⬇️
src/families/solana/api/logged.ts 7.69% <14.28%> (+0.54%) ⬆️
src/families/solana/api/chain/index.ts 68.42% <42.85%> (+60.08%) ⬆️
src/families/solana/js-buildTransaction.ts 68.29% <50.00%> (+58.29%) ⬆️
src/families/solana/js-preload.ts 67.56% <71.42%> (+51.43%) ⬆️
src/families/solana/api/chain/web3.ts 60.34% <75.00%> (+40.34%) ⬆️
src/families/solana/js-prepareTransaction.ts 54.16% <81.81%> (+50.06%) ⬆️
... and 342 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e8169...022d8ef. Read the comment docs.

@ghost ghost changed the base branch from develop to family/solana May 9, 2022 20:23
Comment on lines +32 to +41
throw new Error(
"Your previous transaction hasn't been processed yet. Please wait a moment then check the transaction history before trying again."
);
}

if (e.message.includes("was not confirmed in")) {
throw new Error(
"Your transaction may have failed. Please wait a moment then check the transaction history before trying again."
);
}
Copy link

@ghost ghost Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not certain this works on frontends (LLD & LLM), the text may not be displayed. Even so, it would not be translated.
The way to do it is to just throw specialized errors, that you can add in src/families/solana/errors.ts and on the UI side you can define the english wording for these errors:

@ghost ghost merged commit 692010d into LedgerHQ:family/solana May 9, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant