Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Support/add ci for explorer staging #1914

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

henri-ly
Copy link
Contributor

@henri-ly henri-ly commented Apr 26, 2022

Context (issues, jira)

Support for CI

Description / Usage

We add the ability to run multiple coins in the bot

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@henri-ly henri-ly requested a review from a team April 26, 2022 11:43
@henri-ly henri-ly requested a review from a team as a code owner April 26, 2022 11:43
@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) Apr 27, 2022 at 9:24AM (UTC)

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1914 (16c7096) into develop (76e3f11) will decrease coverage by 10.42%.
The diff coverage is n/a.

❗ Current head 16c7096 differs from pull request most recent head 1bc51f6. Consider uploading reports for the commit 1bc51f6 to get more accurate results

@@             Coverage Diff              @@
##           develop    #1914       +/-   ##
============================================
- Coverage    69.84%   59.42%   -10.43%     
============================================
  Files          545      510       -35     
  Lines        23507    21105     -2402     
  Branches      6185     5687      -498     
============================================
- Hits         16419    12542     -3877     
- Misses        7045     8542     +1497     
+ Partials        43       21       -22     
Impacted Files Coverage Δ
src/families/bitcoin/networks.ts 5.88% <0.00%> (-80.40%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
src/families/crypto_org/js-signOperation.ts 20.31% <0.00%> (-70.32%) ⬇️
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e3f11...1bc51f6. Read the comment docs.

src/bot/index.ts Outdated Show resolved Hide resolved
src/bot/index.ts Outdated Show resolved Hide resolved
all in one file

allow multiple family in env

add schedule + fix naming job

try fix multiple fam

lint

split btc and eth because of seed

revert bot change

add newline at the end of file
@henri-ly henri-ly force-pushed the support/add-ci-for-explorer-staging branch from 31b23ec to 1bc51f6 Compare April 27, 2022 09:16
@henri-ly henri-ly merged commit efcf9b1 into develop Apr 27, 2022
@henri-ly henri-ly deleted the support/add-ci-for-explorer-staging branch April 27, 2022 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant