Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

feature/rating typeform url added to ratings feature flag params #1932

Merged
merged 1 commit into from
May 4, 2022
Merged

feature/rating typeform url added to ratings feature flag params #1932

merged 1 commit into from
May 4, 2022

Conversation

cgrellard-ledger
Copy link
Contributor

Context (issues, jira)

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner May 4, 2022 14:07
@vercel
Copy link

vercel bot commented May 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) May 4, 2022 at 2:15PM (UTC)

@cgrellard-ledger cgrellard-ledger merged commit 855ee87 into develop May 4, 2022
@cgrellard-ledger cgrellard-ledger deleted the feature/rating branch May 4, 2022 14:29
@ghost ghost mentioned this pull request May 4, 2022
Merged
2 tasks
This was referenced May 5, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ofreyssinet-ledger ofreyssinet-ledger ofreyssinet-ledger approved these changes

@nparigi-ledger nparigi-ledger nparigi-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgrellard-ledger @nparigi-ledger @ofreyssinet-ledger