Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Revert change of speculos used for bots #1939

Merged
1 commit merged into from
May 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 5, 2022

Revert #1935

Context (issues, jira)

Latest speculos had an issue which is now fixed, so we can revert to using it.

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost requested review from a team May 5, 2022 08:20
@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) May 5, 2022 at 8:28AM (UTC)

@ghost ghost merged commit 49e8169 into develop May 5, 2022
@ghost ghost deleted the bugfix/revert-speculos-docker-image branch May 5, 2022 08:47
This was referenced May 5, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants