Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-1940 Ledger first inside cosmos validator list #1948

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

henri-ly
Copy link
Contributor

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-1940

Description / Usage

We change how the delegate work on Cosmos according to the new UI.
Also we have some code to clean also because some are unused

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@henri-ly henri-ly requested a review from a team as a code owner May 11, 2022 08:36
@vercel
Copy link

vercel bot commented May 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 13, 2022 at 9:42AM (UTC)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if test datasets are covering the delegate scenarios, as you made some changes in getTransactionStatus and the tests are still passing without changes.

src/families/cosmos/utils.ts Show resolved Hide resolved
src/families/cosmos/react.ts Outdated Show resolved Hide resolved
src/families/cosmos/js-buildTransaction.ts Show resolved Hide resolved
@ghost ghost changed the title Feat/live 1940 ledger first inside cosmos validator list LIVE-1940 Ledger first inside cosmos validator list May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1948 (dc87a51) into develop (6a2af82) will decrease coverage by 0.02%.
The diff coverage is 78.04%.

❗ Current head dc87a51 differs from pull request most recent head 525116f. Consider uploading reports for the commit 525116f to get more accurate results

@@             Coverage Diff             @@
##           develop    #1948      +/-   ##
===========================================
- Coverage    59.42%   59.39%   -0.03%     
===========================================
  Files          510      512       +2     
  Lines        21105    21036      -69     
  Branches      5687     5677      -10     
===========================================
- Hits         12541    12494      -47     
+ Misses        8543     8520      -23     
- Partials        21       22       +1     
Impacted Files Coverage Δ
src/env.ts 65.21% <ø> (ø)
src/exchange/swap/getProviders.ts 58.33% <0.00%> (ø)
src/families/cosmos/logic.ts 43.87% <0.00%> (-0.46%) ⬇️
src/families/cosmos/test-dataset.ts 96.07% <ø> (ø)
src/families/cosmos/validators.ts 61.15% <ø> (ø)
src/families/ripple/test-dataset.ts 100.00% <ø> (ø)
src/families/cosmos/js-signOperation.ts 16.66% <14.28%> (-2.46%) ⬇️
src/families/cosmos/js-buildTransaction.ts 93.18% <71.42%> (-0.94%) ⬇️
src/families/ripple/bridge/js.ts 65.06% <75.60%> (-8.14%) ⬇️
src/families/bitcoin/wallet-btc/wallet.ts 88.32% <77.77%> (+0.17%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b012ce...525116f. Read the comment docs.

@henri-ly henri-ly force-pushed the feat/LIVE-1940-ledger-first-inside-cosmos-validator-list branch from cbfa445 to 525116f Compare May 13, 2022 09:41
@ghost ghost removed the feature ready label May 13, 2022
@ghost ghost added the feature ready label May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant