Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Update Cosmos snapshots for dataset tests #1952

Merged
2 commits merged into from
May 12, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2022

Context (issues, jira)

Not fixing, but waiting for a fix to : https://ledgerhq.atlassian.net/browse/LIVE-2250

Description / Usage

For some reason, a non-frozen dev seed was used to generate test dataset accounts for Cosmos, so every time the accounts in the seed change we need to re-generate the snapshots...
Will be fixed with LIVE-2250

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-requested a review as a code owner May 11, 2022 16:52
@vercel
Copy link

vercel bot commented May 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 12, 2022 at 7:29AM (UTC)

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1952 (1322aba) into develop (a621f96) will increase coverage by 4.25%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1952      +/-   ##
===========================================
+ Coverage    55.21%   59.47%   +4.25%     
===========================================
  Files          450      510      +60     
  Lines        20559    21130     +571     
  Branches      5280     5696     +416     
===========================================
+ Hits         11352    12567    +1215     
+ Misses        9178     8541     -637     
+ Partials        29       22       -7     
Impacted Files Coverage Δ
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-74.51%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-73.85%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
src/families/crypto_org/js-signOperation.ts 20.31% <0.00%> (-70.32%) ⬇️
src/families/celo/js-getTransactionStatus.ts 16.66% <0.00%> (-70.00%) ⬇️
src/families/crypto_org/js-synchronisation.ts 30.00% <0.00%> (-70.00%) ⬇️
... and 356 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a621f96...1322aba. Read the comment docs.

@ghost ghost merged commit 981d4c6 into develop May 12, 2022
@ghost ghost deleted the support/update-cosmos-snapshot branch May 12, 2022 09:20
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants