Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Update stellar-sdk to 10.1.0 #1965

Merged
3 commits merged into from
May 17, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2022

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-2309

Description / Usage

Required for upcoming Stellar network update: https://stellar.org/developers-blog/protocol-19-upgrade-guide
Tested on CLI + LLD + LLM : sync & send

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-assigned this May 17, 2022
@vercel
Copy link

vercel bot commented May 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 17, 2022 at 8:09AM (UTC)

@ghost ghost marked this pull request as ready for review May 17, 2022 07:45
@ghost ghost self-requested a review as a code owner May 17, 2022 07:45
cli/package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1965 (5d9fc01) into develop (663014c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1965      +/-   ##
===========================================
+ Coverage    59.35%   59.38%   +0.02%     
===========================================
  Files          511      511              
  Lines        21017    21017              
  Branches      5666     5666              
===========================================
+ Hits         12475    12480       +5     
+ Misses        8520     8515       -5     
  Partials        22       22              
Impacted Files Coverage Δ
src/range.ts 92.30% <0.00%> (+2.56%) ⬆️
src/network.ts 77.90% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663014c...5d9fc01. Read the comment docs.

@ghost ghost merged commit 2298702 into develop May 17, 2022
@ghost ghost deleted the support/LIVE-2309-update-stellar-sdk branch May 17, 2022 08:51
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants