This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
[LIVE-1174] - Feature: Upgrade NFT architecture #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture
branch
from
d233fe5 to
42d97d0
Compare
Coverage report
Test suite run failedFailed tests: 1/6. Failed suites: 1/2.Report generated by 🧪jest coverage report action from a326406 |
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture
branch
2 times, most recently
from
cf2dd11 to
dd309ad
Compare
|
/generate-screenshots |
This was referenced Apr 1, 2022
juan-cortes
suggested changes
Apr 4, 2022
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture
branch
from
6983a37 to
cb3d031
Compare
juan-cortes
approved these changes
Apr 4, 2022
lambertkevin
added
feature ready
dependencies
|
/generate-screenshots |
ghost
approved these changes
Apr 5, 2022
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture
branch
from
23515a1 to
c4db70f
Compare
|
/generate-screenshots |
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture
branch
from
c4db70f to
6b7c853
Compare
Merged
lambertkevin
added a commit
that referenced
this pull request
Apr 20, 2022
* Add nftMetadataResolver to currencyBridge Proxy * Update DropDowns for NFTs * Update NFT send flow for new NFT model * Update NFT Gallery for new NFT model * Update NFT Collections for new NFT model * Update NFT Viewer for new NFT model * Update operations for new NFT model * Add missing error translation for NFT quantity * Add LLC dependency * Fix NFT send summary showing wrong NFT * Remove all $FlowFixMe for exported memo * Update LLC dep to future v22.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-1174
dependency
LedgerHQ/ledger-live-common#1805
💻 Description / Demo (image or video)
Nothing to show, it should work exactly the same as before 👌
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!