This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LIVE-1766 Add ETH goerli #2349
Merged
LIVE-1766 Add ETH goerli #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, |
ghost
reviewed
Mar 30, 2022
There was a problem hiding this comment.
@hzheng-ledger
Same as on Desktop I think 🙂
- Need to re-generate the cryptoassets.md file
- Maybe need to update the tests/specs/settings/developermode.spec.js test
@haammar-ledger There are no cryptoassets.md and developermode.spec.js test in LLM as far as I am concerned. I think we don't have to update them. Right? |
|
@hzheng-ledger it seems it was deleted recently 😮 idk why but no need anymore indeed. 🙂 |
ghost
added
the
ghost
approved these changes
Apr 29, 2022
ghost
merged commit 
Merged
Merged
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ETH Goerli in LL
https://ledgerhq.atlassian.net/browse/LIVE-1766
Same feature in LLD:
LedgerHQ/ledger-live-desktop#4876