Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LIVE-1774 LIVE-1927 - Add Spanish (ES) and Chinese (ZH) to fully supported languages #2440

Merged
merged 1 commit into from
May 5, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Apr 19, 2022

For users that have their system set in either Chinese or Spanish:

  • new users will have Ledger Live set in that language by default from the start. (cf. following video, with Spanish)

    Simulator.Screen.Recording.-.iPhone.12.-.2022-04-19.at.11.00.12.mp4
  • existing users which had Legder Live in English will see a modal prompting them to switch to that language. (cf. following video, with Spanish)

    Simulator.Screen.Recording.-.iPhone.12.-.2022-04-19.at.10.59.23.mp4

Type

Localization

Context

LIVE-1774
LIVE-1927

Parts of the app affected / Test plan

  • Discoverability for new users (fully supported languages):

    1. Uninstall LL
    2. Switch OS language to Spanish or Chinese (fully supported languages)
    3. Install LL, launch it
    4. LL should be in the system's language
  • Discoverability for new users (not fully supported languages):

    1. Uninstall LL
    2. Switch OS language to a language not fully supported (German for instance)
    3. Install LL, launch it
    4. LL should still be in the English
  • Discoverability for existing users

    1. Uninstall LL
    2. Switch OS language to English
    3. Install LL, launch it, go through onboarding
    4. Quit LL, switch OS language to Spanish or Chinese (resp. a not fully supported language like German)
    5. Launch LL
    6. LL should prompt a dialogue asking the user to switch the language to the OS language (resp. if OS language is not a fully supported language, nothing should happen)

@ofreyssinet-ledger ofreyssinet-ledger self-assigned this Apr 19, 2022
@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team as a code owner April 19, 2022 09:14
Copy link
Contributor

@thomasrogerlux thomasrogerlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep Tech

Base automatically changed from release/v3.0.x to develop April 22, 2022 10:24
@lambertkevin lambertkevin changed the base branch from develop to release/3.1.x May 5, 2022 13:31
@valpinkman valpinkman merged commit e2f5571 into release/3.1.x May 5, 2022
@valpinkman valpinkman deleted the bugfix/discoverability-new-lang branch May 5, 2022 13:39
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants