This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Feat/live 1625 hide nft collection v3 rebased #2452
Merged
lambertkevin
merged 13 commits into
release/3.1.x
from
feat/LIVE-1625-hide-nft-collection-v3-rebased
May 5, 2022
Merged
Feat/live 1625 hide nft collection v3 rebased #2452
lambertkevin
merged 13 commits into
release/3.1.x
from
feat/LIVE-1625-hide-nft-collection-v3-rebased
May 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambertkevin
changed the base branch from
develop
to
feat/upgrade-nft-architecture-v3
April 26, 2022 14:03
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
from
April 26, 2022 14:04
313888d
to
6449447
Compare
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
2 times, most recently
from
May 2, 2022 18:14
f0fb664
to
286ec39
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
May 2, 2022 18:26
af43ece
to
e5434d7
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
May 2, 2022 18:37
e5434d7
to
93bf5d6
Compare
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
from
May 2, 2022 18:47
286ec39
to
84884a4
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
2 times, most recently
from
May 4, 2022 15:37
a33d188
to
93b5b67
Compare
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
from
May 4, 2022 15:40
84884a4
to
d55b826
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
May 4, 2022 15:50
93b5b67
to
0d94747
Compare
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
from
May 4, 2022 15:50
d55b826
to
2662777
Compare
lambertkevin
changed the base branch from
feat/upgrade-nft-architecture-v3
to
develop
May 4, 2022 16:11
lambertkevin
changed the base branch from
develop
to
feat/upgrade-nft-architecture-v3
May 4, 2022 16:14
juan-cortes
approved these changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about my suggestion, but otherwise looks ok to me.
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
3 times, most recently
from
May 4, 2022 20:10
99aedc7
to
46d9068
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
May 4, 2022 20:23
3811eb2
to
f6bd615
Compare
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
from
May 4, 2022 20:23
46d9068
to
c312393
Compare
lambertkevin
changed the base branch from
feat/upgrade-nft-architecture-v3
to
develop
May 4, 2022 20:24
lambertkevin
changed the base branch from
develop
to
feat/upgrade-nft-architecture-v3
May 5, 2022 08:42
lambertkevin
changed the base branch from
feat/upgrade-nft-architecture-v3
to
release/3.1.x
May 5, 2022 13:32
Co-authored-by: Juan Cortés Ross <[email protected]>
Co-authored-by: Juan Cortés Ross <[email protected]>
lambertkevin
force-pushed
the
feat/LIVE-1625-hide-nft-collection-v3-rebased
branch
from
May 5, 2022 14:05
53d2115
to
d0b6c79
Compare
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #2333
This PR adds the possibility of hiding NFT collections from both the account page and the NFT Gallery page.
The hidden collections are visible in the account settings page and can be unhidden there.
Screen_Recording_20220324-171322_LL.DEV.mp4
Type
Feature
Context
LIVE-1625
Parts of the app affected / Test plan
Account page, NFT Gallery and Setting page.
On an account page, long-press an NFT collection to show the hide menu.
On the NFT Gallery, click the 3 dots beside the collection title to show the hide menu.
Go to settings -> accounts -> hidden NFT collections to unhide the collections.
Hidden collections should not be visible in the account page nor the NFT gallery.