Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Feat/live 1625 hide nft collection v3 rebased #2452

Merged

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Apr 26, 2022

Copy of #2333

This PR adds the possibility of hiding NFT collections from both the account page and the NFT Gallery page.
The hidden collections are visible in the account settings page and can be unhidden there.

Screen_Recording_20220324-171322_LL.DEV.mp4

Type

Feature

Context

LIVE-1625

Parts of the app affected / Test plan

Account page, NFT Gallery and Setting page.
On an account page, long-press an NFT collection to show the hide menu.
On the NFT Gallery, click the 3 dots beside the collection title to show the hide menu.
Go to settings -> accounts -> hidden NFT collections to unhide the collections.
Hidden collections should not be visible in the account page nor the NFT gallery.

@lambertkevin lambertkevin changed the base branch from develop to feat/upgrade-nft-architecture-v3 April 26, 2022 14:03
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch from 313888d to 6449447 Compare April 26, 2022 14:04
@lambertkevin lambertkevin marked this pull request as ready for review April 29, 2022 10:47
@lambertkevin lambertkevin requested a review from a team as a code owner April 29, 2022 10:47
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch 2 times, most recently from f0fb664 to 286ec39 Compare May 2, 2022 18:14
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from af43ece to e5434d7 Compare May 2, 2022 18:26
@lambertkevin lambertkevin requested review from a team as code owners May 2, 2022 18:26
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from e5434d7 to 93bf5d6 Compare May 2, 2022 18:37
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch from 286ec39 to 84884a4 Compare May 2, 2022 18:47
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch 2 times, most recently from a33d188 to 93b5b67 Compare May 4, 2022 15:37
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch from 84884a4 to d55b826 Compare May 4, 2022 15:40
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from 93b5b67 to 0d94747 Compare May 4, 2022 15:50
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch from d55b826 to 2662777 Compare May 4, 2022 15:50
@lambertkevin lambertkevin changed the base branch from feat/upgrade-nft-architecture-v3 to develop May 4, 2022 16:11
@lambertkevin lambertkevin changed the base branch from develop to feat/upgrade-nft-architecture-v3 May 4, 2022 16:14
Copy link
Contributor

@juan-cortes juan-cortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about my suggestion, but otherwise looks ok to me.

src/components/Touchable.js Outdated Show resolved Hide resolved
src/screens/Settings/Accounts/index.tsx Outdated Show resolved Hide resolved
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch 3 times, most recently from 99aedc7 to 46d9068 Compare May 4, 2022 20:10
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from 3811eb2 to f6bd615 Compare May 4, 2022 20:23
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch from 46d9068 to c312393 Compare May 4, 2022 20:23
@lambertkevin lambertkevin changed the base branch from feat/upgrade-nft-architecture-v3 to develop May 4, 2022 20:24
@lambertkevin lambertkevin added the dependencies Pull requests that update a dependency file label May 4, 2022
@lambertkevin lambertkevin changed the base branch from develop to feat/upgrade-nft-architecture-v3 May 5, 2022 08:42
@lambertkevin lambertkevin changed the base branch from feat/upgrade-nft-architecture-v3 to release/3.1.x May 5, 2022 13:32
@lambertkevin lambertkevin force-pushed the feat/LIVE-1625-hide-nft-collection-v3-rebased branch from 53d2115 to d0b6c79 Compare May 5, 2022 14:05
@lambertkevin lambertkevin merged commit 6538f69 into release/3.1.x May 5, 2022
@lambertkevin lambertkevin deleted the feat/LIVE-1625-hide-nft-collection-v3-rebased branch May 5, 2022 14:06
@lambertkevin lambertkevin mentioned this pull request May 5, 2022
@lambertkevin lambertkevin restored the feat/LIVE-1625-hide-nft-collection-v3-rebased branch May 6, 2022 10:53
@lambertkevin lambertkevin deleted the feat/LIVE-1625-hide-nft-collection-v3-rebased branch May 6, 2022 10:56
@lambertkevin lambertkevin mentioned this pull request May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants