Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Add to README more info on pre-requisites #2461

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Apr 29, 2022

Modifications in the ## Pre-requisites section of the README:

  • Adding link to official React Native environment setup instructions.
  • ### Android section:
    • Adding JDK 11 requirement.
    • Adding NDK & CMake with exact versions and how to install them.

Screenshot 2022-04-29 at 11 53 48

Type

Documentation

Context

I got a new M1 mac so I'm setting up the environment and some necessary information is missing from the README

@ofreyssinet-ledger ofreyssinet-ledger self-assigned this Apr 29, 2022
@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team as a code owner April 29, 2022 09:52
@github-actions
Copy link

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

Copy link
Contributor

@elbywan elbywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 👍

@ofreyssinet-ledger ofreyssinet-ledger merged commit 9184e52 into develop Apr 29, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the support/update-readme-pre-requisites branch April 29, 2022 09:59
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants