Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Conversation

nparigi-ledger
Copy link
Contributor

Use hide empty sub account setting on accounts list

Type

Bug fix

Context

https://ledgerhq.atlassian.net/browse/LIVE-2028

Parts of the app affected / Test plan

Accounts

@nparigi-ledger nparigi-ledger requested a review from a team as a code owner April 29, 2022 13:54
@ofreyssinet-ledger
Copy link
Contributor

@nparigi-ledger I see 2 things on the ticket that don't seem to be reflected in the code changes:

  • this "hiding" of accounts should be determined by some user settings (and maybe it should be hidden by default, idk if that has to be changed)
  • there is a mention of some copy to update

@nparigi-ledger
Copy link
Contributor Author

@nparigi-ledger I see 2 things on the ticket that don't seem to be reflected in the code changes:

  • this "hiding" of accounts should be determined by some user settings (and maybe it should be hidden by default, idk if that has to be changed)
  • there is a mention of some copy to update
  • This modification takes into account the user setting. Basically this change adds a parameter to flattenAccount so that it takes into account this setting.
  • I forgot that, thank you @ofreyssinet-ledger

Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and approved 👍

@ofreyssinet-ledger ofreyssinet-ledger merged commit d9d123a into develop May 2, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the fix/LIVE-2028-user-shouldnt-see-empty-token-accounts-if-hide-empty-token-account-feature-is-enabled-wording branch May 2, 2022 13:45
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants