Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Add polygon and BSC to supported chains for WalletConnect #2473

Conversation

ofreyssinet-ledger
Copy link
Contributor

reopening this PR #2443 from a correctly named branch


Add polygon and BSC to supported chains for WalletConnect instead of just Ethereum

Type

Feature

Context

https://ledgerhq.atlassian.net/browse/LIVE-2004

Parts of the app affected / Test plan

Can be tested with this URL

Account page -> walletconnect
Deeplink -> walletconnect

@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team as a code owner May 2, 2022 14:22
@github-actions
Copy link

github-actions bot commented May 2, 2022

Thanks for your contribution.
To be groomed for next release, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Copy link
Contributor Author

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also tested with Polygon on Android (signing an authentication message for opensea) ✅

@lambertkevin lambertkevin changed the base branch from develop to release/3.1.x May 5, 2022 13:30
@valpinkman valpinkman merged commit 92b51f8 into release/3.1.x May 5, 2022
@valpinkman valpinkman deleted the feat/LIVE-2004-merge-wallet-connect-p-rs-and-port-the-work-done-to-mobile branch May 5, 2022 13:31
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants