Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LIVE-2111: Fix wallet recommended section carousel v2 to v3 migration #2480

Merged
merged 3 commits into from
May 5, 2022

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented May 4, 2022

Before:

The recommended section is missing from the Wallet page when updating the app from v2 to v3.

carousel-before.mp4

After:

The recommended section is displayed when updating the app from v2 to v3.

carousel-after-visible.mp4

Type

Bug fix

Context

LIVE-2111

Parts of the app affected / Test plan

"Wallet" screen -> "Recommended" section (carousel with cards)

Install v2, go through the onboarding, then install v3 and check that the "Recommended" section is here.

@ofreyssinet-ledger ofreyssinet-ledger self-assigned this May 4, 2022
@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team as a code owner May 4, 2022 09:44
@github-actions
Copy link

github-actions bot commented May 4, 2022

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

@lambertkevin lambertkevin changed the base branch from develop to release/3.1.x May 5, 2022 13:29
@valpinkman valpinkman merged commit 36061c3 into release/3.1.x May 5, 2022
@valpinkman valpinkman deleted the bugfix/carousel-v2-migration branch May 5, 2022 13:30
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants