This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
[LIVE-2320] - Bugfix: Fix missing import for Clipboard #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
May 11, 2022
| @@ -17,6 +17,7 @@ import { BigNumber } from "bignumber.js"; | |||
| import { useSelector } from "react-redux"; | |||
| import { Button, Icons } from "@ledgerhq/native-ui"; | |||
| import { useTranslation, Trans } from "react-i18next"; | |||
| import Clipboard from "@react-native-community/clipboard"; | |||
There was a problem hiding this comment.
I'm wondering how it could build before without that import 🤔
There was a problem hiding this comment.
We don't have any CI anymore on TS files... So that + everything is red in VSCode cause we don't have either the proper configuration, or we didn't take the time to actually fix all of our errors, it makes it almost impossible to catch this kind of things...
lambertkevin
changed the title
lambertkevin
force-pushed
the
bugfix/clipboard-crash
branch
2 times, most recently
from
9daffb8 to
0be6c23
Compare
lambertkevin
force-pushed
the
bugfix/clipboard-crash
branch
from
0be6c23 to
78dc867
Compare
ychen-ledger
approved these changes
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIVE-2320
Type
Bugfix
Context
RPReplay_Final1652259395.mov
clipboard.mp4
Parts of the app affected / Test plan
Go to NFT Viewer & click on any "copy" button