Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnose lockfile #8238

Merged
merged 1 commit into from
Oct 29, 2024
Merged

diagnose lockfile #8238

merged 1 commit into from
Oct 29, 2024

Conversation

themooneer
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:13pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:13pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:13pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:13pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:13pm

@themooneer themooneer merged commit 6416fb9 into develop Oct 29, 2024
15 of 20 checks passed
@themooneer themooneer deleted the fix/pnpm-lock-issue branch October 29, 2024 14:13
Canestin pushed a commit that referenced this pull request Oct 30, 2024
chore: fix lockfile missing deps issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant