feat: ✨ SpamFiltering for NFTs TX in LLM #8241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
mcayuelas-ledger
force-pushed
the
feat/spam-filtering-tx-useNFTfilter-LLD
branch
from
a96bcd1 to
5a9c4c3
Compare
mcayuelas-ledger
force-pushed
the
feat/spam-filtering-tx-LLM
branch
from
0cf8861 to
996b053
Compare
live-github-bot
bot
added
desktop
mcayuelas-ledger
force-pushed
the
feat/spam-filtering-tx-useNFTfilter-LLD
branch
from
5a9c4c3 to
3f90142
Compare
mcayuelas-ledger
force-pushed
the
feat/spam-filtering-tx-LLM
branch
from
996b053 to
ad5da1f
Compare
live-github-bot
bot
removed
desktop
mcayuelas-ledger
changed the title
mcayuelas-ledger
force-pushed
the
feat/spam-filtering-tx-LLM
branch
2 times, most recently
from
e22fd43 to
9b4a1fc
Compare
Base automatically changed from
feat/spam-filtering-tx-useNFTfilter-LLD
to
develop
October 31, 2024 12:51
mcayuelas-ledger
dismissed stale reviews from KVNLS and themooneer
The base branch was changed.
- Adding filtering in Operations - Rework of HiddenCollection display - Add Whitelist - Rework hooks
mcayuelas-ledger
force-pushed
the
feat/spam-filtering-tx-LLM
branch
from
b0415c4 to
7b2f128
Compare
themooneer
approved these changes
Oct 31, 2024
ofreyssinet-ledger
approved these changes
Oct 31, 2024
KVNLS
approved these changes
Oct 31, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.Covered by automatic tests.
Impact of the changes:
Transaction Filtering:
Implementation of a new feature to filter transactions involving spam NFTs. This ensures that only valid and relevant transactions are considered within the system.
Whitelist and Enhancement of HiddenCollection:
Addition of a whitelist to control the addresses and accounts authorized to interact with the system, enhancing the security and reliability of processed transactions.
Improvements made to the HiddenCollection object to optimize the management and storage of hidden NFT collections.
Automatic Synchronization:
Implementation of automatic synchronization every 6 hours to refresh and filter NFTs via the Simplehash API. This ensures that the data remains up-to-date and relevant.
Refresh on Account Addition:
When new accounts or addresses are added, the filtering request is automatically re-triggered. This guarantees that new entries are immediately taken into account in the filtering process.
Add loading "Hiddencollections" to avoid load everything fully
📝 Description
useNftCollectionsinstead ofuseNFTGalleryFiltereverywhereuseSyncNFTsWithAccountsis used and works exactly the same as LLDPuffer.mov
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-14034
🧐 Checklist for the PR Reviewers