🐛(lld) hedera split address #8381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
LucasWerey
force-pushed
the
fix/LIVE-14751
branch
from
5da329a to
fbc4d21
Compare
KVNLS
previously requested changes
Nov 20, 2024
|
|
||
| // FIXME why not using CSS for this? meaning we might be able to have a left & right which both take 50% & play with overflow & text-align | ||
| const left = value.slice(0, third); | ||
| const right = value.slice(third, value.length); | ||
| let left, right; |
There was a problem hiding this comment.
We need a unit test here. Please extract this into a dedicated function that returns left and right and we can check all possibilities.
LucasWerey
force-pushed
the
fix/LIVE-14751
branch
from
fbc4d21 to
7685898
Compare
Comment on lines
27
to
41
| let left, right; | ||
| if (value.includes(".")) { | ||
| const parts = value.split("."); | ||
| left = parts[0] + "."; | ||
| right = parts.slice(1).join("."); | ||
| } else { | ||
| const third = Math.round(value.length / 3); | ||
| left = value.slice(0, third); | ||
| right = value.slice(third, value.length); | ||
| } | ||
|
|
There was a problem hiding this comment.
You should put this part outside your component, and add unit test :)
There was a problem hiding this comment.
Yes I will I just did a rebase
LucasWerey
force-pushed
the
fix/LIVE-14751
branch
from
7685898 to
0c8a0c0
Compare
mcayuelas-ledger
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Split address didn't consider special characters that's why hedera address was strangely displayed. The bug was surely with all other coin with address containing special chars
All other addresses won't be affected since we now use a condition
This may change the splitting since we are based on the dots but Hedera might be the only to have addresses with special char in it
Note
The behaviour has been validated by Product since the split with dots of an Hedera address should be rare. And there is no other addresses like this AFAWK
❓ Context
🧐 Checklist for the PR Reviewers