Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartling on-demand translation delivery from release #8522

Merged
merged 20 commits into from
Nov 28, 2024

Conversation

ldg-smartling-sa
Copy link
Collaborator

Please review this manually triggered translation push from the configuration set 'ledger-live - json - Pull Request' in your Smartling project https://dashboard.smartling.com/app/projects/be90da906/github-connector/configurationSets/f7e47f48e176

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:02am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:02am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:02am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:02am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Nov 28, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Nov 28, 2024

Desktop Bundle Checks

Comparing 2289434 against 0aa6ec9.

🚀 renderer bundle size decreased (38.6mb -> 37.4mb). Thanks ❤️
⚠️ @ethersproject/abi library is now duplicated in renderer (regression)
⚠️ readable-stream library is now duplicated in renderer (regression)
⚠️ safe-buffer library is now duplicated in renderer (regression)
⚠️ eth-lib/lib/hash library is now duplicated in renderer (regression)
⚠️ fp-ts/lib/Either library is now duplicated in renderer (regression)
⚠️ ethereumjs-util library is now duplicated in renderer (regression)
⚠️ io-ts library is now duplicated in renderer (regression)
⚠️ @celo/connect/lib/utils/formatter library is now duplicated in renderer (regression)
⚠️ @celo/wallet-base library is now duplicated in renderer (regression)
⚠️ multibase library is now duplicated in renderer (regression)
⚠️ multicodec library is now duplicated in renderer (regression)
⚠️ isarray library is now duplicated in renderer (regression)
⚠️ eth-lib/lib/bytes library is now duplicated in renderer (regression)
🚀 ethereum-cryptography/secp256k1 library is no longer duplicated in renderer
🚀 @noble/hashes/_assert library is no longer duplicated in renderer
🚀 @ethereumjs/rlp library is no longer duplicated in renderer
🚀 ethereum-cryptography/keccak library is no longer duplicated in renderer
🚀 ethereum-cryptography/utils library is no longer duplicated in renderer
🚀 @ethereumjs/util library is no longer duplicated in renderer
🚀 cross-fetch library is no longer duplicated in renderer
🚀 @sentry/utils library is no longer duplicated in renderer
🚀 xstate library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing 2289434 against 0aa6ec9.

🚀 main.ios.jsbundle bundle size decreased (64.4mb -> 63.3mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (64.4mb -> 63.3mb). Thanks ❤️

@@ -1485,7 +1486,7 @@
},
"earn" : {
"title" : "تكديس",
"description" : "كدّس أصولك المشفرة مع Ledger"
"description" : "Get rewards on your crypto"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arabic translation problem here.

Copy link
Contributor

@themooneer themooneer Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR introduced issues in arabic translation on this file , starting from line 1290

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with deutschland translation here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here , new values are in english , wrong translations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@desirendr desirendr merged commit ec7f405 into release Nov 28, 2024
48 of 49 checks passed
@desirendr desirendr deleted the smartling-translations-20241128113940019 branch November 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants