Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sortByMarketcap.test.ts.snap #8533

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

themooneer
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@themooneer themooneer requested a review from a team as a code owner November 28, 2024 16:49
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 28, 2024 4:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 4:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 4:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 4:58pm

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Nov 28, 2024

Desktop Bundle Checks

Comparing b5adb25 against d4058aa.

πŸš€ renderer bundle size decreased (38.6mb -> 37.4mb). Thanks ❀️
⚠️ @ethersproject/abi library is now duplicated in renderer (regression)
⚠️ readable-stream library is now duplicated in renderer (regression)
⚠️ safe-buffer library is now duplicated in renderer (regression)
⚠️ eth-lib/lib/hash library is now duplicated in renderer (regression)
⚠️ fp-ts/lib/Either library is now duplicated in renderer (regression)
⚠️ ethereumjs-util library is now duplicated in renderer (regression)
⚠️ io-ts library is now duplicated in renderer (regression)
⚠️ @celo/connect/lib/utils/formatter library is now duplicated in renderer (regression)
⚠️ @celo/wallet-base library is now duplicated in renderer (regression)
⚠️ multibase library is now duplicated in renderer (regression)
⚠️ multicodec library is now duplicated in renderer (regression)
⚠️ isarray library is now duplicated in renderer (regression)
⚠️ eth-lib/lib/bytes library is now duplicated in renderer (regression)
πŸš€ ethereum-cryptography/secp256k1 library is no longer duplicated in renderer
πŸš€ @noble/hashes/_assert library is no longer duplicated in renderer
πŸš€ @ethereumjs/rlp library is no longer duplicated in renderer
πŸš€ ethereum-cryptography/keccak library is no longer duplicated in renderer
πŸš€ ethereum-cryptography/utils library is no longer duplicated in renderer
πŸš€ @ethereumjs/util library is no longer duplicated in renderer
πŸš€ cross-fetch library is no longer duplicated in renderer
πŸš€ @sentry/utils library is no longer duplicated in renderer
πŸš€ xstate library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing b5adb25 against 51920d6.

πŸš€ main.ios.jsbundle bundle size decreased (64.4mb -> 63.3mb). Thanks ❀️
πŸš€ main.android.jsbundle bundle size decreased (64.4mb -> 63.3mb). Thanks ❀️

@themooneer themooneer merged commit 90d248d into release Nov 28, 2024
52 of 55 checks passed
@themooneer themooneer deleted the tests/updateSnapshot branch November 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants