Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ LLM - Upgrade react native from 0.74.88 to 0.75.4 #8599

Merged
merged 5 commits into from
Dec 18, 2024
Merged

⬆️ LLM - Upgrade react native from 0.74.88 to 0.75.4 #8599

merged 5 commits into from
Dec 18, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Dec 4, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Upgrade react native from 0.74.88 to 0.75.4
Removed expo-barcode-scanner that was only installed to use a constant string
Added a patch for the react-native-fast-crypto library that isn't maintained anymore and wasn't compiling on android

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 3:24pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 3:24pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 3:24pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 3:24pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM ui Has changes in the design system library tools Has changes in tools labels Dec 4, 2024
@cgrellard-ledger cgrellard-ledger marked this pull request as ready for review December 4, 2024 16:14
@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner December 4, 2024 16:14
@cgrellard-ledger cgrellard-ledger force-pushed the support/upgrade-react-native-to-v0.75.4 branch from 5b11da7 to 0dd514e Compare December 5, 2024 10:42
@cgrellard-ledger cgrellard-ledger force-pushed the support/upgrade-react-native-to-v0.75.4 branch from e80cc57 to dcd80d9 Compare December 5, 2024 14:24
@cgrellard-ledger cgrellard-ledger force-pushed the support/upgrade-react-native-to-v0.75.4 branch from dcd80d9 to 1f803ee Compare December 5, 2024 15:21
@live-github-bot live-github-bot bot removed the tools Has changes in tools label Dec 5, 2024
@cgrellard-ledger cgrellard-ledger force-pushed the support/upgrade-react-native-to-v0.75.4 branch from 1f803ee to 408ea4b Compare December 5, 2024 15:24
@cgrellard-ledger cgrellard-ledger force-pushed the support/upgrade-react-native-to-v0.75.4 branch from 408ea4b to b3987c5 Compare December 9, 2024 09:26
@abdurrahman-ledger abdurrahman-ledger requested a review from a team as a code owner December 11, 2024 10:29
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/upgrade-react-native-to-v0.75.4 branch from df2b47f to d7abb17 Compare December 11, 2024 12:44
thesan
thesan previously approved these changes Dec 13, 2024
View reviewed changes
thesan
thesan previously approved these changes Dec 17, 2024
View reviewed changes
@cgrellard-ledger cgrellard-ledger merged commit 88f3190 into develop Dec 18, 2024
65 of 69 checks passed
@cgrellard-ledger cgrellard-ledger deleted the support/upgrade-react-native-to-v0.75.4 branch December 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@LucasWerey LucasWerey LucasWerey approved these changes

@thesan thesan thesan approved these changes

@abdurrahman-ledger abdurrahman-ledger abdurrahman-ledger left review comments

@bharamboure-ledger bharamboure-ledger Awaiting requested review from bharamboure-ledger

Assignees

@cgrellard-ledger cgrellard-ledger

Labels
mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cgrellard-ledger @thesan @LucasWerey @ypolishchuk-ledger @bharamboure-ledger @abdurrahman-ledger