Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ (llm) new accounts and assets lists portfolio #8663

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: ✨ (llm) new accounts and assets lists portfolio #8663

merged 1 commit into from
Dec 17, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Dec 10, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Wallet screen
    • Native UI

📝 Description

Important

There is a test that's not working properly because of the animation. It looks like the shared values are not updated so the translation and the opacity change don't happen in test env. It has been decided to just check if the row exists

Integration of the new assets and accounts lists to the current portfolio screen.
useListsAnimation.ts has the logic that ensure the animation of the tab switch is smooth.
Creation of a new component in the navite lib. I've renamed the current component to DrawerTabComponent since it's used only in a drawer and it looks more like a drawer tab selector.
Since the rename of the DrawerTabComponent is out of the scope I didn't change anything in it just a rename
Also reduce the margin top of the quick actions
Remove bottom edger on Accounts and Assets lists screens

Storybook link : https://native-ui-storybook-git-feat-live-14723-ledgerhq.vercel.app/?path=/docs/form-tabselector--docs

ANIMATIONS DEMO

Simulator.Screen.Recording.-.iPhone.15.-.2024-12-11.at.10.29.58.mp4
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-12-11.at.10.42.30.mp4

USE CASES DEMO

Simulator.Screen.Recording.-.iPhone.15.-.2024-12-13.at.18.10.19.mp4

QUICK ACTIONS MARGIN

image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
native-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 3:00pm
web-tools ❌ Failed (Inspect) Dec 16, 2024 3:00pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 3:00pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 3:00pm

@LucasWerey LucasWerey changed the title feat: ✨ (llm): new accounts and assets lists portfolio feat: ✨ (llm) new accounts and assets lists portfolio Dec 10, 2024
@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Dec 10, 2024
@LucasWerey LucasWerey force-pushed the feat/LIVE-14723 branch 3 times, most recently from bca80ac to 3a428dd Compare December 10, 2024 18:41
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 10, 2024 •
edited
Loading

Mobile Bundle Checks

Comparing e4d6473 against eafb5d9.

✅ Previous issues have all been fixed.

@LucasWerey LucasWerey force-pushed the feat/LIVE-14723 branch 2 times, most recently from e926af9 to 4404653 Compare December 10, 2024 19:49
@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Dec 10, 2024
@LucasWerey LucasWerey marked this pull request as ready for review December 10, 2024 19:55
@LucasWerey LucasWerey requested a review from a team as a code owner December 10, 2024 19:55
@LucasWerey LucasWerey marked this pull request as draft December 10, 2024 19:57
@LucasWerey LucasWerey force-pushed the feat/LIVE-14723 branch 4 times, most recently from b99c47c to d4a2120 Compare December 13, 2024 17:16
@LucasWerey LucasWerey marked this pull request as ready for review December 16, 2024 10:37
themooneer
themooneer reviewed Dec 16, 2024
View reviewed changes
apps/ledger-live-mobile/src/screens/Portfolio/ListsSection.tsx Outdated
maxItemsToDysplay: number;
};

const ListsSection: React.FC<ListsSectionProps> = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest a TabSection name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@LucasWerey
feat: ✨ (llm): new accounts and assets lists portfolio
b422984 
feat: ✨ (llm): inte test

feat: ✨ (llm): inte test

feat: ✨ (llm): enhance tab selector

feat: ✨ (llm): inte test
themooneer
themooneer approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucasWerey LucasWerey merged commit 8223e21 into develop Dec 17, 2024
48 of 52 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-14723 branch December 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@LucasWerey LucasWerey

Labels
mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasWerey @themooneer