Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA] Activating USDC swaps tests #8702

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[QAA] Activating USDC swaps tests #8702

merged 1 commit into from
Dec 17, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Dec 16, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

❓ Context

  • **JIRA or GitHub

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:57am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:57am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:57am

@live-github-bot live-github-bot bot added desktop Has changes in LLD automation CI/CD stuff labels Dec 16, 2024
@VicAlbr VicAlbr marked this pull request as ready for review December 16, 2024 15:47
@VicAlbr VicAlbr requested review from a team as code owners December 16, 2024 15:47
@VicAlbr VicAlbr force-pushed the support/enable-broadcast-on-demand branch from 3957609 to 426b696 Compare December 17, 2024 09:56
@live-github-bot live-github-bot bot removed the automation CI/CD stuff label Dec 17, 2024
@VicAlbr VicAlbr force-pushed the support/enable-broadcast-on-demand branch from 426b696 to 7dc68fa Compare December 17, 2024 09:57
@VicAlbr VicAlbr changed the title [QAA-372] Enable broadcast on demand [QAA] Activating USDC swaps tests Dec 17, 2024
@VicAlbr VicAlbr merged commit 2b68cf2 into develop Dec 17, 2024
43 of 45 checks passed
@VicAlbr VicAlbr deleted the support/enable-broadcast-on-demand branch December 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharamboure-ledger bharamboure-ledger bharamboure-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

Assignees

@VicAlbr VicAlbr

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VicAlbr @ypolishchuk-ledger @bharamboure-ledger