Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ (llm)add new accounts list to wallet centric screen #8717

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Dec 17, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • wallet centric

πŸ“ Description

To make sure to have the possibility to render accountsList inside walletCentric I've added a props with specific accounts that the component should render. From this if there is specific accounts we set the redirection of the add accounts button. If there is specific accounts it means that we are on wallet centric screen or with only accounts of a certain asset so it redirects directly to the good flow without choosing asset. If not we open the drawer.

This way we ensure that the flow remains the same as today with more flexibility on the components

Simulator.Screen.Recording.-.iPhone.15.-.2024-12-18.at.16.24.46.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 1:54pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 1:54pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 1:54pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 1:54pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Dec 17, 2024
@LucasWerey LucasWerey marked this pull request as ready for review December 18, 2024 15:31
@LucasWerey LucasWerey requested a review from a team as a code owner December 18, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants