Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto rewards withdrawal #8770

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pavanvora
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

With the upcoming Cardano hard fork every Cardano wallet will be required to participate in governance by selecting a DRep and without doing so they won't be able to withdraw the rewards.

The current implementation has auto withdrawal of the rewards, which will break after the hard fork. This is a work around PR so users can continue using their wallet as normal with their rewards being locked until the DRep feature gets implemented to Ledger Live.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@pavanvora pavanvora requested a review from a team as a code owner December 27, 2024 17:30
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 5:31pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 5:31pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2024 5:31pm

Copy link

vercel bot commented Dec 27, 2024

@pavanvora is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added the fork Pull request base branch comes from a fork. label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork Pull request base branch comes from a fork.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant