Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hot fix tx expiration #8791

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

may01
Copy link

@may01 may01 commented Jan 2, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix rejected transaction validation after expiration timeout, after saving estimated.expirationTimestampSecs to tx.options.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@may01 may01 requested review from a team as code owners January 2, 2025 17:34
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 2, 2025 7:51pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 7:51pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 7:51pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 7:51pm

@may01 may01 changed the base branch from develop to feat/integrate-aptos January 2, 2025 17:34
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common translations Translation files have been touched cli labels Jan 2, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 2, 2025

Desktop Bundle Checks

Comparing 03b1b82 against 8d2cf10.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 03b1b82 against 8d2cf10.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched cli labels Jan 2, 2025
@may01 may01 merged commit 8aee213 into feat/integrate-aptos Jan 2, 2025
51 of 54 checks passed
may01 added a commit that referenced this pull request Jan 2, 2025
* Hot fix of transaction expiration
* Fix integration tests
@may01 may01 deleted the feat/hot-fix-tx-expiration branch January 2, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants