Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aptos): enhancements corrections #8798

Merged

Conversation

jccguimaraes
Copy link
Member

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Adds enhancements and rollback some unneeded changes, added corrections.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jccguimaraes jccguimaraes requested review from a team as code owners January 3, 2025 14:51
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 4:29pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:29pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:29pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:29pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Jan 3, 2025
@jccguimaraes jccguimaraes changed the base branch from develop to feat/integrate-aptos January 3, 2025 14:55
@live-github-bot live-github-bot bot removed ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels Jan 3, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 3, 2025

Desktop Bundle Checks

Comparing c668aed against a070f4e.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing c668aed against a070f4e.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

@jccguimaraes jccguimaraes merged commit 4e7b8e3 into feat/integrate-aptos Jan 3, 2025
54 checks passed
@jccguimaraes jccguimaraes deleted the fix/LIVE-15591_enhancements_corrections branch January 3, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants