Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: casper coin modularization #8878

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

feat: casper coin modularization #8878

wants to merge 12 commits into from

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Jan 13, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Casper Coin Modularization

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested a review from a team as a code owner January 13, 2025 08:48
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:00am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:00am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:00am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:00am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Jan 13, 2025
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch 2 times, most recently from 6c56528 to 9bcdecb Compare January 13, 2025 14:37
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 9bcdecb to 12b1818 Compare January 13, 2025 14:46
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 12b1818 to dbc2b71 Compare January 13, 2025 15:03
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jan 13, 2025
qperrot
qperrot reviewed Jan 14, 2025
View reviewed changes
libs/coin-modules/coin-casper/package.json Show resolved Hide resolved
libs/coin-modules/coin-casper/package.json Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/common-logic/utils.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/signer/getAddress.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/signer/getAddress.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/package.json Outdated Show resolved Hide resolved
.changeset/chatty-days-buy.md Outdated Show resolved Hide resolved
apps/ledger-live-mobile/src/families/casper/TransactionConfirmFields.tsx Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/package.json Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/bridge/broadcast.ts Show resolved Hide resolved
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from fb8d5a9 to 66538a7 Compare January 15, 2025 12:30
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 15, 2025
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 16, 2025
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 16, 2025
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 41e3ce1 to bfca297 Compare January 16, 2025 13:57
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from e70b7ac to a127e1d Compare January 21, 2025 09:22
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

[Bot] Testing with 'Nitrogen' ✅ 1 txs ($356.22) ⏲ 71.9s

✅ 1 specs are successful: Casper

What is the bot and how does it work? Everything is documented here!

Details of the 1 mutations

Spec Casper (8)

Spec Casper found 8 Casper accounts. Will use Casper 2.6.8 on nanoSP 1.1.2
undefined: 32.1 CSPR (80ops) (02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c on 44'/506'/0'/0/0) casper_wallet#0 js:2:casper:02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c:casper_wallet
undefined: 0 CSPR (76ops) (02034a7c5519d553bc282f768dca044e18746b7be9b711f2f310c190f33b3cbc4a4f on 44'/506'/0'/0/1) casper_wallet#1 js:2:casper:02034a7c5519d553bc282f768dca044e18746b7be9b711f2f310c190f33b3cbc4a4f:casper_wallet
undefined: 3,124.98 CSPR (59ops) (0203b56bc181780f8fb173bafd8d483d6911282ec46d72692d0a5bbbb29ea242ed76 on 44'/506'/0'/0/2) casper_wallet#2 js:2:casper:0203b56bc181780f8fb173bafd8d483d6911282ec46d72692d0a5bbbb29ea242ed76:casper_wallet
undefined: 3,122.33 CSPR (75ops) (0203d14bf1367769813e9c7233db26dc2208ca211532a0c2b1189992dc01d4bc098e on 44'/506'/0'/0/3) casper_wallet#3 js:2:casper:0203d14bf1367769813e9c7233db26dc2208ca211532a0c2b1189992dc01d4bc098e:casper_wallet
undefined: 0 CSPR (60ops) (02039ae761a635a37868cf35e6de9799cba9fc4cdb9a3afbba6ab5c83291f13bbec8 on 44'/506'/0'/0/4) casper_wallet#4 js:2:casper:02039ae761a635a37868cf35e6de9799cba9fc4cdb9a3afbba6ab5c83291f13bbec8:casper_wallet
undefined: 0 CSPR (35ops) (02033ceac656c99270c432fd59a60102b4e807977f67c429298ea3436f2ce41a1b1b on 44'/506'/0'/0/5) casper_wallet#5 js:2:casper:02033ceac656c99270c432fd59a60102b4e807977f67c429298ea3436f2ce41a1b1b:casper_wallet
undefined: 18,731.6 CSPR (39ops) (02035addb3ef3863b0b44054e638f7c61f74319d5da70b8e98fef9ea984f7db6edac on 44'/506'/0'/0/6) casper_wallet#6 js:2:casper:02035addb3ef3863b0b44054e638f7c61f74319d5da70b8e98fef9ea984f7db6edac:casper_wallet
undefined: 0 CSPR (0ops) (0202b75fd56f06b03e675b33b0a136b6c87810c5a0435281dfe567c79596e0876fa4 on 44'/506'/0'/0/7) casper_wallet#7 js:2:casper:0202b75fd56f06b03e675b33b0a136b6c87810c5a0435281dfe567c79596e0876fa4:casper_wallet
necessary accounts resynced in 0.22ms
▬ Casper 2.6.8 on nanoSP 1.1.2
→ FROM undefined: 32.1 CSPR (80ops) (02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c on 44'/506'/0'/0/0) casper_wallet#0 js:2:casper:02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c:casper_wallet
max spendable ~32
★ using mutation 'Send ~50%'
→ TO undefined: 0 CSPR (60ops) (02039ae761a635a37868cf35e6de9799cba9fc4cdb9a3afbba6ab5c83291f13bbec8 on 44'/506'/0'/0/4) casper_wallet#4 js:2:casper:02039ae761a635a37868cf35e6de9799cba9fc4cdb9a3afbba6ab5c83291f13bbec8:casper_wallet
✔️ transaction 
SEND  16 CSPR
TO 02039ae761a635a37868cf35e6de9799cba9fc4cdb9a3afbba6ab5c83291f13bbec8
STATUS (2.63ms)
  amount: 16 CSPR
  estimated fees: 0.1 CSPR
  total spent: 16.1 CSPR
errors: 
warnings: 
✔️ has been signed! (3.1s) 
✔️ broadcasted! (365ms) optimistic operation: 
  -16.1 CSPR         OUT        f904e074ef73eb05ba42987d4a13f2930cfde26eec9b4bbc83ea702fff2cc623 2025-01-21T10:52
✔️ operation confirmed (33s): 
  -16.1 CSPR         OUT        f904e074ef73eb05ba42987d4a13f2930cfde26eec9b4bbc83ea702fff2cc623 2025-01-21T10:52
✔️ undefined: 16 CSPR (81ops) (02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c on 44'/506'/0'/0/0) casper_wallet#0 js:2:casper:02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c:casper_wallet(in 33s)
✔️ destination operation 
  +16 CSPR           IN         f904e074ef73eb05ba42987d4a13f2930cfde26eec9b4bbc83ea702fff2cc623 2025-01-21T10:52
(in 12.5s)
Portfolio ($356.22) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Casper (8) 426 ops (+2), 25,011.1 CSPR ($356.22) 💪 999+ 02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c 
undefined: 16 CSPR (81ops) (02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c on 44'/506'/0'/0/0) casper_wallet#0 js:2:casper:02026b93627ed2f76551e7cef0466468b12db8fab806266107b69947d9c95ced9e7c:casper_wallet
undefined: 0 CSPR (76ops) (02034a7c5519d553bc282f768dca044e18746b7be9b711f2f310c190f33b3cbc4a4f on 44'/506'/0'/0/1) casper_wallet#1 js:2:casper:02034a7c5519d553bc282f768dca044e18746b7be9b711f2f310c190f33b3cbc4a4f:casper_wallet
undefined: 3,124.98 CSPR (59ops) (0203b56bc181780f8fb173bafd8d483d6911282ec46d72692d0a5bbbb29ea242ed76 on 44'/506'/0'/0/2) casper_wallet#2 js:2:casper:0203b56bc181780f8fb173bafd8d483d6911282ec46d72692d0a5bbbb29ea242ed76:casper_wallet
undefined: 3,122.33 CSPR (75ops) (0203d14bf1367769813e9c7233db26dc2208ca211532a0c2b1189992dc01d4bc098e on 44'/506'/0'/0/3) casper_wallet#3 js:2:casper:0203d14bf1367769813e9c7233db26dc2208ca211532a0c2b1189992dc01d4bc098e:casper_wallet
undefined: 16 CSPR (61ops) (02039ae761a635a37868cf35e6de9799cba9fc4cdb9a3afbba6ab5c83291f13bbec8 on 44'/506'/0'/0/4) casper_wallet#4 js:2:casper:02039ae761a635a37868cf35e6de9799cba9fc4cdb9a3afbba6ab5c83291f13bbec8:casper_wallet
undefined: 0 CSPR (35ops) (02033ceac656c99270c432fd59a60102b4e807977f67c429298ea3436f2ce41a1b1b on 44'/506'/0'/0/5) casper_wallet#5 js:2:casper:02033ceac656c99270c432fd59a60102b4e807977f67c429298ea3436f2ce41a1b1b:casper_wallet
undefined: 18,731.6 CSPR (39ops) (02035addb3ef3863b0b44054e638f7c61f74319d5da70b8e98fef9ea984f7db6edac on 44'/506'/0'/0/6) casper_wallet#6 js:2:casper:02035addb3ef3863b0b44054e638f7c61f74319d5da70b8e98fef9ea984f7db6edac:casper_wallet
undefined: 0 CSPR (0ops) (0202b75fd56f06b03e675b33b0a136b6c87810c5a0435281dfe567c79596e0876fa4 on 44'/506'/0'/0/7) casper_wallet#7 js:2:casper:0202b75fd56f06b03e675b33b0a136b6c87810c5a0435281dfe567c79596e0876fa4:casper_wallet
Performance ⏲ 71.9s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 1.05ms 20.6s 1.22ms 2.63ms 3.1s 365ms 33s 12.5s
Casper (7) 1.05ms 20.6s 1.22ms 2.63ms 3.1s 365ms 33s 12.5s

What is the bot and how does it work? Everything is documented here!

@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 21, 2025
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 22, 2025
ComradeAERGO
ComradeAERGO previously approved these changes Jan 24, 2025
View reviewed changes
@Wozacosta Wozacosta force-pushed the LIVE-13677-casper-coin-module branch from 4e94674 to bfacb4c Compare January 27, 2025 10:44
Wozacosta
Wozacosta previously approved these changes Jan 27, 2025
View reviewed changes
@Wozacosta
Copy link
Contributor

Wozacosta commented Jan 27, 2025 •
edited by live-github-bot bot
Loading

@Wozacosta

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@github-actions github-actions bot requested review from a team as code owners January 27, 2025 11:27
@Wozacosta Wozacosta force-pushed the LIVE-13677-casper-coin-module branch from aba67d9 to 7e2606e Compare January 27, 2025 11:53
@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qperrot qperrot qperrot left review comments

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@Wozacosta Wozacosta Wozacosta approved these changes

@ComradeAERGO ComradeAERGO ComradeAERGO left review comments

Assignees

@Canestin Canestin

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM screenshots Screenshots have been updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Canestin @Wozacosta @qperrot @ComradeAERGO @ypolishchuk-ledger