[QAA] Refactoring layout class #8941
Open
+151
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
VicAlbr
force-pushed
the
support/qaa-80
branch
from
762b976 to
63f8aa9
Compare
| @@ -15,4 +18,14 @@ export class LockscreenPage extends AppPage { | |||
| async lostPassword() { | |||
| await this.forgottenButton.click(); | |||
| } | |||
|
|
|||
| @step("Check input error state visibibility: $0") | |||
| async checkInputErrorVisibibility(expectedState: "visible" | "hidden") { | |||
There was a problem hiding this comment.
typo in method name
| @@ -133,4 +137,37 @@ export class SendModal extends Modal { | |||
| await this.cryptoAmountField.fill(amount); | |||
| } | |||
| } | |||
|
|
|||
| @step("Check input error state visibibility: $0") | |||
| async checkInputErrorVisibibility(expectedState: "visible" | "hidden") { | |||
| } | ||
|
|
||
| @step("Check warning message") | ||
| async checkAmoutWarningMessage(expectedWarningMessage: RegExp) { |
|
|
||
| @step("Wait for balance to be visible") | ||
| async expectBalanceVisibility() { | ||
| await this.totalBalance.waitFor({ state: "visible" }); |
There was a problem hiding this comment.
I see that we also have in the account.page an element with the same test id "total-balance" defined. It would be better if we can disassociate both (maybe in another ticket)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Refacto layout class:
❓ Context
🧐 Checklist for the PR Reviewers