Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(live-14726): llm spacing internalization #9129

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(live-14726): llm spacing internalization #9129

wants to merge 1 commit into from
+14 −9

Conversation

liviuciulinaru
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • change tabs title
  • fix bottom padding for iOS
SCR-20250206-npuo-2

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested a review from a team as a code owner February 6, 2025 08:24
@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 8:30am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 8:30am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 8:30am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 8:30am

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Feb 6, 2025
@liviuciulinaru
fix: spacing, sizes
1e3e035 
chore: changeset
@liviuciulinaru liviuciulinaru force-pushed the fix/live-14726/llm-ui-fixes branch from c9b1684 to 1e3e035 Compare February 6, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallen-ledger kallen-ledger kallen-ledger approved these changes

@ejaycoleman ejaycoleman ejaycoleman approved these changes

Assignees

@liviuciulinaru liviuciulinaru

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liviuciulinaru @ejaycoleman @kallen-ledger