Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VG-750 VG-9256 VG-6129 fix(explorer): Return explorer error in broadcast error message #936

Merged
merged 1 commit into from
May 31, 2023
Merged

VG-750 VG-9256 VG-6129 fix(explorer): Return explorer error in broadcast error message #936

merged 1 commit into from
May 31, 2023
+14 −3

Conversation

BertrandD
Copy link
Contributor

@BertrandD BertrandD commented May 30, 2023 •
edited
Loading

Fixes VG-750
Fixes VG-9256
Fixes VG-6129

Fix to have explorer error message in WD's response

Previously we had:

{
	"type": "Internal_Error",
	"message": {
		"response": "Internal server error occurred while processing the request. Bad Request"
	}
}

Now we have:

{
	"type": "Internal_Error",
	"message": {
		"response": "Internal server error occurred while processing the request. Got explorer error: -25: bad-txns-inputs-missingorspent"
	}
}

@BertrandD BertrandD changed the title VG-750 fix(explorer): Return explorer error in broadcast error message VG-750 VG-9256 fix(explorer): Return explorer error in broadcast error message May 30, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BertrandD BertrandD changed the title VG-750 VG-9256 fix(explorer): Return explorer error in broadcast error message VG-750 VG-9256 VG-6129 fix(explorer): Return explorer error in broadcast error message May 30, 2023
jcoatelen-ledger
jcoatelen-ledger approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool, nice to see it coming !
we can add it for other coins later though
LGTM

@BertrandD BertrandD merged commit d98d283 into main May 31, 2023
@BertrandD BertrandD deleted the fix/explorer_error_message branch May 31, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoatelen-ledger jcoatelen-ledger jcoatelen-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BertrandD @jcoatelen-ledger