+ #87
Merged
+ #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g sniffed data (#18898) * Create rev_1715713909070959500.sql * extra leftovers
Referenced commit(s): fd7c8a0
…#18764) * fix(Scripts/PVP): correctly spawn generic gameobjects in Alterac Valley I've been "collecting" these in the DB for a while, now it's time to move these spawns to the AV script and actually spawn them. * add 2 additional generic gameobjects
Referenced commit(s): e2029c3
…kes (#18883) * init * fixes
* fix(CI/PCH): revert ubuntu-22.04 to gcc12, add ubuntu-24.04 with gcc14 * also update nopch workflow * Update core-build-nopch.yml * Update core-build-pch.yml
Referenced commit(s): 4ae69cf
…18907) add quality colors to .item lookup command
Referenced commit(s): 49e3d5d
… lines to supp… (#18917) * (DB/SQL)add missing broadcastID to Elder Clearwater txt lines to support localization * Update kaluac.sql
Referenced commit(s): 64833d9
Referenced commit(s): cf8c155
* Init. * Remove auxiliary comments. * Readd comments along with original reward values. * Remove auxiliary comments again. * Add important commit regarding data accuracy. * Move comment.
Referenced commit(s): 346456f
…l when talking to Bran (#18927) load Mimiron's and Thorim's Targetting crystal
#18928) fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enrage/outro
Referenced commit(s): 0aaf521
* fix movement of doomfire * fix air burst * conditions * movechase random target * Update boss_archimonde.cpp * update movement * Update boss_archimonde.cpp * Update boss_archimonde.cpp
Referenced commit(s): f78820e
… function (#18932) initial
Referenced commit(s): 9c7cf93
…19134) * instance_azjol_nerub spell:spell_azjol_nerub_fixate * instance_azjol_nerub aura:spell_azjol_nerub_web_wrap_aura * boss_hadronox aura:spell_hadronox_summon_periodic_aura * boss_hadronox aura:spell_hadronox_leech_poison_aura * boss_argent_challenge spell:spell_eadric_radiance * boss_argent_challenge spell:spell_toc5_light_rain * boss_argent_challenge aura:spell_reflective_shield_aura * fixup! boss_argent_challenge aura:spell_reflective_shield_aura * instance_drak_tharon_keep aura:spell_dtk_raise_dead_aura * instance_drak_tharon_keep spell:spell_dtk_summon_random_drakkari * boss_trollgore spell:spell_trollgore_consume * boss_trollgore aura:spell_trollgore_corpse_explode_aura * boss_trollgore spell:spell_trollgore_invader_taunt * boss_novos spell:spell_novos_despawn_crystal_handler * boss_novos aura:spell_novos_crystal_handler_death_aura * boss_novos spell:spell_novos_summon_minions * boss_tharon_ja aura:spell_tharon_ja_curse_of_life_aura * boss_tharon_ja aura:spell_tharon_ja_dummy_aura * boss_tharon_ja spell:spell_tharon_ja_clear_gift_of_tharon_ja * boss_dred aura:spell_dred_grievious_bite_aura * boss_dred spell:spell_dred_raptor_call * boss_moorabi aura:spell_moorabi_mojo_frenzy_aura * boss_slad_ran aura:spell_sladran_grip_of_sladran_aura * boss_drakkari_colossus spell:spell_drakkari_colossus_emerge * boss_drakkari_colossus spell:spell_drakkari_colossus_surge * boss_drakkari_colossus spell:spell_drakkari_colossus_face_me * boss_gal_darah spell:spell_galdarah_impaling_charge * boss_gal_darah spell:spell_galdarah_transform * boss_malygos spell:spell_eoe_ph3_surge_of_power * oculus aura:spell_oculus_stop_time_aura * oculus aura:spell_oculus_evasive_maneuvers_aura * oculus spell:spell_oculus_shock_lance * oculus aura:spell_oculus_temporal_rift_aura * oculus spell:spell_oculus_touch_the_nightmare * oculus aura:spell_oculus_dream_funnel_aura * oculus spell:spell_oculus_call_ruby_emerald_amber_drake * oculus aura:spell_oculus_ride_ruby_emerald_amber_drake_que_aura * oculus aura:spell_oculus_evasive_charges_aura * oculus aura:spell_oculus_soar_aura * oculus aura:spell_oculus_rider_aura * oculus aura:spell_oculus_drake_flag_aura * boss_magus_telestra aura:spell_boss_magus_telestra_summon_telestra_clones_aura * boss_magus_telestra spell:spell_boss_magus_telestra_gravity_well * utgarde_keep aura:spell_ticking_time_bomb_aura * boss_keleseth aura:spell_frost_tomb_aura * boss_svala pair:spell_svala_ritual_strike * boss_moragg aura:spell_optic_link_aura * violet_hold aura:spell_destroy_door_seal_aura * forge_of_souls aura:spell_shield_of_bones_aura * boss_devourer_of_souls aura:spell_wailing_souls_periodic_aura * boss_bronjahm spell:spell_bronjahm_magic_bane * boss_bronjahm aura:spell_bronjahm_soulstorm_channel_ooc_aura * boss_bronjahm aura:spell_bronjahm_soulstorm_visual_aura * boss_bronjahm spell:spell_bronjahm_soulstorm_targeting * boss_krickandick aura:spell_krick_explosive_barrage_aura * boss_krickandick aura:spell_exploding_orb_auto_grow_aura * pit_of_saron aura:spell_pos_empowered_blizzard_aura * pit_of_saron spell:spell_pos_slave_trigger_closest * pit_of_saron spell:spell_pos_rimefang_frost_nova * pit_of_saron aura:spell_pos_blight_aura * pit_of_saron aura:spell_pos_glacial_strike_aura * boss_forgemaster_garfrost spell:spell_garfrost_permafrost * halls_of_reflection aura:spell_hor_gunship_cannon_fire_aura * boss_marwyn aura:spell_hor_shared_suffering_aura * fixup! forge_of_souls aura:spell_shield_of_bones_aura * fixup! boss_bronjahm aura:spell_bronjahm_soulstorm_channel_ooc_aura * fixup! boss_bronjahm aura:spell_bronjahm_soulstorm_visual_aura * fixup! pit_of_saron aura:spell_pos_empowered_blizzard_aura * fixup! halls_of_reflection aura:spell_hor_gunship_cannon_fire_aura * fixup! boss_marwyn aura:spell_hor_shared_suffering_aura
Referenced commit(s): cd9dff5
#19141) fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject spawns - properly spawn bonfire spell focus for city bonfires - properly despawn unwanted creatures and gameobjects which are spawned by linked traps - all midsummer bonfire gameobjects have a linked trap "181290 Midsummer Bonfire Spawn Trap" - the trap is linked to the spell "28784 Summon Midsummer Bonfire Bunnies" which then spawns npc "16592 Midsummer Bonfire", npc "16606 Midsummer Bonfire Despawner" and gameobject "181371 Midsummer Bonfire Spell Focus" i have no idea how this trap is beeing triggered, but it's doing only harm right now
Referenced commit(s): 3d03cb6
…pt_fiend_aura (#19142) rename other args fixup cd9dff5#commitcomment-143444310
Referenced commit(s): 240314e
Referenced commit(s): 81225e4
…es. (#19149) * Init. * Whoops.
Referenced commit(s): 5e423b3
* Init. * Forgot the heroic difficulty entry, not base.
Referenced commit(s): b2457ef
* zone_terokkar_forest pair:spell_q10930_big_bone_worm * zone_terokkar_forest spell:spell_q10036_torgos * zone_terokkar_forest spell:spell_q10923_evil_draws_near_summon * zone_terokkar_forest aura:spell_q10923_evil_draws_near_periodic_aura * zone_terokkar_forest spell:spell_q10923_evil_draws_near_visual * zone_terokkar_forest spell:spell_q10898_skywing * zone_hellfire_peninsula spell:spell_q10935_the_exorcism_of_colonel_jules * boss_doomlord_kazzak aura:spell_mark_of_kazzak_aura * zone_blades_edge_mountains aura:spell_npc22275_crystal_prison_aura * zone_blades_edge_mountains spell:spell_oscillating_field * zone_shadowmoon_valley spell:spell_q10612_10613_the_fel_and_the_furious * zone_shadowmoon_valley aura:spell_q10563_q10596_to_legion_hold_aura * fixup! zone_hellfire_peninsula spell:spell_q10935_the_exorcism_of_colonel_jules fixup! zone_hellfire_peninsula spell:spell_q10935_the_exorcism_of_colonel_jules * fixup! zone_blades_edge_mountains aura:spell_npc22275_crystal_prison_aura * fixup! zone_shadowmoon_valley spell:spell_q10612_10613_the_fel_and_the_furious * fixup! zone_blades_edge_mountains spell:spell_oscillating_field * zone_terokkar_forest pair:spell_q10929_fumping
Referenced commit(s): 7a77a3e
Referenced commit(s): ce0b1ad
Referenced commit(s): b1fc1c3
* fix(Core/Spells): Script Drunken Haze & Drunken Skull Crack * bruh * sigh
* fix(DB/Formations): Link Durnholde Lodges * ? * ??
* fix(DB/SAI): Lashh'an Talonite pets * creature_text * )
Referenced commit(s): cc31430
* fix(DB/SAI): Tormented Soul & Soulbind spell * 20480 is just for looks * allowOverride 0 * ... * Set Reactstate Aggressive
Referenced commit(s): c3fd593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.