Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev profile to strip symbols and disable debug info (ref #3610) #3611

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Jul 13, 2023

This significantly speeds up builds:

  • with strip symbols and debug 0: 43s
  • without: 169s

This significantly speeds up builds:
- with strip symbols and debug 0: 43s
- without: 169s
@Nutomic Nutomic changed the title WIP: Remove SendActivity and Perform traits, rely on channel Add dev profile to strip symbols and disable debug info (ref #3610) Jul 13, 2023
@phiresky
Copy link
Collaborator

Would be good to try with just debug=0 because those symbols are really useful for stack traces (e.g. anyhow errors, the use of tracing spans isn't consistent everywhere) and i think they are stripped only after the compilation process anyways?

also a comment would be good referencing the issue so no one tries to remove it again like i would

@Nutomic
Copy link
Member Author

Nutomic commented Jul 13, 2023

Okay updated the measurements. Somehow Im still getting inconsistent results with the same build command taking sometimes 2 minutes and then 5 minutes for no reason. Anyway it looks like only debug 0 is needed, so I updated it like that and added a comment.

@dessalines dessalines merged commit 39f28c1 into main Jul 13, 2023
Nutomic added a commit to cetra3/lemmy that referenced this pull request Jul 19, 2023
…#3610) (LemmyNet#3611)

* Add dev profile to strip symbols and disable debug info (ref LemmyNet#3610)

This significantly speeds up builds:
- with strip symbols and debug 0: 43s
- without: 169s

* add comment, no strip symbols
Nutomic added a commit that referenced this pull request Jul 21, 2023
…3611)

* Add dev profile to strip symbols and disable debug info (ref #3610)

This significantly speeds up builds:
- with strip symbols and debug 0: 43s
- without: 169s

* add comment, no strip symbols
Nutomic added a commit that referenced this pull request Jul 21, 2023
…3611)

* Add dev profile to strip symbols and disable debug info (ref #3610)

This significantly speeds up builds:
- with strip symbols and debug 0: 43s
- without: 169s

* add comment, no strip symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants