Make resolve_object not require auth #3685 #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user isn't authenticated with resolve_object, only allow a local search instead of possibly making an http request.
|
It doesn't look like this is actually blocking invalid tokens. I'll push an update tonight to fix that. |
|
Fixed the issue where I wasn't properly locking invalid tokens. |
Nutomic
reviewed
Jul 26, 2023
| context: &Data<LemmyContext>, | ||
| ) -> Result<SearchableObjects, LemmyError> { | ||
| let url = Url::parse(query)?; | ||
| ObjectId::from(url).dereference_local(context).await |
There was a problem hiding this comment.
You can directly call ObjectId::parse which calls Url::parse internally. And in fact it doesnt make much sense to have a separate function for this single line. Otherwise looks good.
Nutomic
approved these changes
Jul 26, 2023
dessalines
approved these changes
Jul 26, 2023
| @@ -84,7 +84,7 @@ pub struct SearchResponse { | |||
| pub struct ResolveObject { | |||
| /// Can be the full url, or a shortened version like: [email protected] | |||
| pub q: String, | |||
| pub auth: Sensitive<String>, | |||
| pub auth: Option<Sensitive<String>>, | |||
There was a problem hiding this comment.
API change, but it shouldn't be breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #3685
If user isn't authenticated with resolve_object, only allow a local search instead of possibly making an http request.
Changing resolve_object to take an optional auth parameter. When auth is null, the request is only allowed to search the local database rather than do a remote lookup.
This is primarily to resolve a few issue:
/api/v3/post...on every Lemmy instance in the fediverse, is extremely slow. Current estimate, is around ~13 years worst case, if no new posts get added.Original PR for reference: #3706 (as it was easier to decline that one and open a new one with the requested changes).