Remove redundant field CommentLike.post_id #4749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dullbananas
requested review from
dessalines,
phiresky,
Nutomic and
SleeplessOne1917
as code owners
| @@ -59,7 +59,7 @@ impl VoteView { | |||
|
|
|||
| comment_like::table | |||
| .inner_join(person::table) | |||
| .inner_join(post::table) | |||
| .inner_join(comment::table.inner_join(post::table)) | |||
There was a problem hiding this comment.
Is there a difference in logic or performance if we put each of these individually on the top level chain? i.e.
comment_like::table
.inner_join(person::table)
.inner_join(comment::table)
.inner_join(post::table)
// etc.There was a problem hiding this comment.
There should be no difference because only 5 tables are joined, and the join collapse limit is set to 11, which means the database ignores the given join order
SleeplessOne1917
approved these changes
May 28, 2024
|
Lets mark as draft until |
dullbananas
changed the title
|
I'll mark as ready to review, since we're merging breaking changes now. |
Nutomic
approved these changes
Sep 16, 2024
|
The migration for this one is dependent on #4459 , so luckily the CI will catch this until that one gets merged. |
dessalines
approved these changes
Sep 16, 2024
|
Included in #5122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required byrequires #4459