upgrade to nodejs 18.18.2 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
requested changes
Nov 17, 2023
| @@ -1 +1 @@ | |||
| nodejs 16.15.1 | |||
| nodejs 18.18.2 | |||
There was a problem hiding this comment.
Found a few more places to update:
- Readme was already out of date, but should be updated:
_parquet.js requires node.js >= 14.16.0_ - The GitHub Action workflows still use v16. 18+ might require updating the version of the
actions/checkout,actions/setup-node, andactions/cacheactions, although I think the new version of setup-node might not require theactions/cacheanymore.
There was a problem hiding this comment.
I created another upgrade issue with these items in a checklist.
There was a problem hiding this comment.
That sounds good. More of an Actions upgrade issue.
There was a problem hiding this comment.
looks like CI is ok with the actions versions for now. maybe add it to the next upgrade issue?
wilwade
approved these changes
Nov 17, 2023
| @@ -1 +1 @@ | |||
| nodejs 16.15.1 | |||
| nodejs 18.18.2 | |||
There was a problem hiding this comment.
That sounds good. More of an Actions upgrade issue.
wilwade
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Upgrade to nodejs 18+. Closes #83
Solution
Used last patch version of nodejs 18
Change summary:
npm installto update package-lock.jsonSteps to Verify:
CI should pass