Linting and Formatting #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ignore for dist
Manual Type fixes
wilwade
force-pushed
the
chore/lint-format-34
branch
from
863e85b to
91ae9ac
Compare
mattheworris
approved these changes
Jul 1, 2024
shannonwells
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
I scanned the changes starting w/ the last file & going up, FWIW, all looks like normal formatting/style lints.
There are at least two sets of rules in the default settings that IMO are inconsistent and/or make the code less readable and not more. We can quibble about that later, since the point of this is just to get the linting and formatting integrated.
| let reader; | ||
|
|
||
| const listArraySchema = new parquet.ParquetSchema({ |
There was a problem hiding this comment.
just noting this was moved up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Note: I split this into different commits so it would be easy to review that which wasn't automatically applied.
I suggest reviewing those commits instead of every line.
Problem
Styles and potential issues were all over without enforcing linting and formatting.
Closes: #34
Solution
Added linting and formatting.
Change summary:
Steps to Verify: