UI improvements #51
Merged
UI improvements #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return _cursor; | ||
| } | ||
|
|
||
| unsigned int CadMdiChild::id() { |
There was a problem hiding this comment.
should we change the _id type to "unsigned long long"?
even though it's mostly 32 bit for "unsigned int", the C++ standard only requires "unsigned int" type to be at least 16 bit.
I suppose we need 64 bit to avoid collision on a busy system.
There was a problem hiding this comment.
If _id is only 16 bits that makes 65536 new documents, that's possible if someone never close the program.
I think the better solution is to reuse the id of closed documents, then all the windows would have to be opened at the same time to obtain a collision. It should be possible by calling a Lua function with Qt destroyed event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.