Incorrect bottom height calculation in table cell

[rammetzger]

For long texts (more than one page) within a table cell, it can happen that a line is printed twice. One time on the last page and one time on the next. The cause is an incorrect calculation of the available cell height.

The bug is in the calculation of cell height in class PdfPRow on lines 609-612:

float bottom = cell.getTop() + cell.getEffectivePaddingBottom() - newHeight;
float top = cell.getTop() - cell.getEffectivePaddingTop();

The bottom value does not consider EffectivePaddingTop. The code should look something like this:

float top = cell.getTop() - cell.getEffectivePaddingTop();
float bottom = top + cell.getEffectivePaddingBottom() - newHeight;

Please take over the correction in one of the next versions.
Thanks in advance.

[andreasrosdal]

https://github.com/LibrePDF/OpenPDF/blob/master/openpdf/src/main/java/com/lowagie/text/pdf/PdfPRow.java#L609

Pull requests welcome!

[PalAditya]

Added a PR (#260) to help out with this 😁

[andreasrosdal]

@rammetzger Can you please verify that this has been fixed in the master branch?

[rammetzger]

Hi Andreas, the bug seems to be fixed. I can’t reproduce it any more. Thanks for the quick fix. Viele Grüße / Best regards Michael Metzger Von: Andreas Rosdal <[email protected]> Gesendet: Montag, 16. September 2019 17:45 An: LibrePDF/OpenPDF <[email protected]> Cc: Michael Metzger | RA Consulting <[email protected]>; Mention <[email protected]> Betreff: Re: [LibrePDF/OpenPDF] Incorrect buttom height calculation in table cell (#258) @rammetzger<https://github.com/rammetzger> Can you please verify that this has been fixed in the master branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#258?email_source=notifications&email_token=ANGPUYSQTRLFMP5UDTEB2Z3QJ6SWNA5CNFSM4IW6JFDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ZSX7Q#issuecomment-531835902>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ANGPUYRGWKM73AVIEFHSIULQJ6SWNANCNFSM4IW6JFDA>.