Small refactoring - moved rectangle normalization into PdfRectangle constructor to avoid issues with using this constructor in the future #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed redundant usage of PdfRectangle
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature
As suggested here #1116 (review)
Small refactoring applied for PdfRectangle - the fix moved into constructor to avoid similar bugs in the future.
Related Issue: #1116
Unit-Tests for the new Feature/Bugfix
[-] No new tests added, existing Unit-Tests covers the changes
Compatibilities Issues
not known, not expected
Testing details
Tested by existing unit tests