Fixes Producer metadata manipulation in Stamper

.gitignore

@@ -181,3 +181,6 @@ buildNumber.properties
 *.html
 
 *.pdf
+#Allow pdf as source resources for testing
+!openpdf/src/test/resources/*.pdf
+

openpdf/src/main/java/com/lowagie/text/pdf/PdfStamperImp.java

@@ -225,7 +225,7 @@ void close(Map<String, String> moreInfo) throws IOException {
           skipInfo = iInfo.getNumber();
         }
         if (oldInfo != null && oldInfo.get(PdfName.PRODUCER) != null) {
-          producer = oldInfo.getAsString(PdfName.PRODUCER).toString();
+          producer = oldInfo.getAsString(PdfName.PRODUCER).toUnicodeString();
         }
         if (producer == null) {
           producer = Document.getVersion();

openpdf/src/test/java/com/lowagie/text/pdf/metadata/ProducerTest.java

@@ -1,23 +1,26 @@
 package com.lowagie.text.pdf.metadata;
 
-import com.lowagie.text.Document;
-import com.lowagie.text.Paragraph;
-import com.lowagie.text.pdf.PdfReader;
-import com.lowagie.text.pdf.PdfWriter;
-
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
+import java.io.File;
 import java.io.IOException;
 import java.util.Map;
+
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import com.lowagie.text.Document;
+import com.lowagie.text.Paragraph;
+import com.lowagie.text.pdf.PdfReader;
+import com.lowagie.text.pdf.PdfStamper;
+import com.lowagie.text.pdf.PdfWriter;
+
 public class ProducerTest {
 
     private static final String PRODUCER = "Producer";
 
     @Test
-    void changeProducerLineTest() throws IOException {
+    public void changeProducerLineTest() throws IOException {
         String expected = "New Producer.";
 
         Document document = new Document();
@@ -40,4 +43,18 @@ void changeProducerLineTest() throws IOException {
 
         reader.close();
     }
+
+    @Test
+    public void testMetadataProducerStamperIssue254 () throws IOException {
+        File origin = new File("src/test/resources/pdf_form_metadata_issue_254.pdf");
+        ByteArrayOutputStream baos = new ByteArrayOutputStream();
+        PdfReader reader = new PdfReader(origin.getAbsolutePath());
+        PdfStamper stamp = new PdfStamper(reader, baos);
+        stamp.close();
+        byte[] data = baos.toByteArray();
+        String sData = new String(data);
+        Assertions.assertTrue(sData.contains("(LibreOffice 6.0; modified using OpenPDF"));        
+
+
+    }
 }