Fix LGTM Errors #278
Merged
Fix LGTM Errors #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noavarice
suggested changes
Oct 4, 2019
pdf-toolbox/src/test/java/com/lowagie/examples/objects/bookmarks/PageLabels.java
Outdated
Show resolved
Hide resolved
pdf-toolbox/src/test/java/com/lowagie/examples/objects/bookmarks/PageLabels.java
Outdated
Show resolved
Hide resolved
pdf-toolbox/src/test/java/com/lowagie/examples/objects/bookmarks/PageLabels.java
Outdated
Show resolved
Hide resolved
This an online application evaluating the quality of the code. Something like Sonar. |
noavarice
suggested changes
Oct 4, 2019
noavarice
reviewed
Oct 4, 2019
pdf-toolbox/src/test/java/com/lowagie/examples/objects/bookmarks/PageLabels.java
Outdated
Show resolved
Hide resolved
noavarice
suggested changes
Oct 4, 2019
pdf-toolbox/src/test/java/com/lowagie/examples/objects/bookmarks/PageLabels.java
Outdated
Show resolved
Hide resolved
|
Let me know if it's ok for you and I'll squash the commits with a more meaningful message |
noavarice
approved these changes
Oct 5, 2019
asturio
approved these changes
Oct 5, 2019
In PdfPageLabels#getPageLabelFormat() keys were considered as Integer when they were PdfNumber. This could lead to errors due to incompatble types.
sixdouglas
force-pushed
the
fix/FixLgtmErrors
branch
from
8ff1eaa to
1a85e21
Compare
|
Commits squashed and message rephrased. |
|
Thank you guys for this review. |
|
@andreasrosdal I don't see the automatic build from Travis. Is it a visibility problem? |
asturio
approved these changes
Oct 6, 2019
|
@andreasrosdal I'm sorry to hear about your retirement. Thank you for all the time spent and your welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix LGTM Errors (link to the issue #128 )
No breaking changes