Issue747: fix wrong layout of generating a table with alignment setting #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
The strange layout or endless loop is caused by wrong position of the first line in cell which sets alignment not as TOP. After searching the codes deeper, I find it forgets to change contentHeight after modifying line.height with adding correct alignment space. In this way, I just add the missing part on contentHeight for the first line and it works perfectly!
Related Issue: #747
Unit-Tests for the new Feature/Bugfix
Before fixing:
After fixing:
Compatibilities Issues
There are no compatibility problems with the new code so far.
Testing details
I create two Junit tests to examine.