fix slow or OutOfMemory in SmartCopy with some pdfs #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @albfernandez , the checkstyle problems were fixed on master. Can you please rebase your branch onto OpenPdf/master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
In some pfs, using pdfsmartcopy can lead to a very slow and in some cases to an OutOfMemoryError.
PdfSmartCopy has a limit of 100 recursive levels, but it run all 100 levels,
With this change, when the limit is reached the "smart" copy is aborted for that object and normal copy is used.
Provided a tests case and a sample "broken" pdf example file.
Without the patch, the pdfsmartcopy takes some minutes, with the patch it only takes a few seconds.
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
No
Testing details
NO