-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding lighbits cinder driver support #3
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I know nothing about kolla
.. cinder-guide-Lightbits: | ||
|
||
===================================== | ||
Lightbits labs storage for OpenStack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just drop the "labs" here. If you want to keep it, it needs to be capitalized, as the name is "Lightbits Labs", not "Lightbits labs".
Lightbits labs storage for OpenStack | ||
===================================== | ||
|
||
Lightbits labs Cinder Driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same and same everyone you have "labs"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuval-lb Will this change the content of this page ?
https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/lightbits-lightos-driver.html
I've plan to create patch to update these pages .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if yes then we want to merge this patch asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahman-lb no, this guide will be part of the kolla-ansible project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got you, i'll take care of the other.
we want to add our plugin to kolla-ansible to have easy installation process.
@muliby-lb please check the "cinder-guide-lighbits.rst" page if you have anything to add/change