Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: Fix XFS fs type regression #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dockerfile: Fix XFS fs type regression #52

wants to merge 2 commits into from

Conversation

husam-lb
Copy link
Collaborator

@husam-lb husam-lb commented Aug 12, 2024 •
edited
Loading

XFS has a habit of being incompatible with userspace when it comes to default fs options. This time with fs options: bigtime=1 inobtcount=1 are enabled by default in new xfsprogs and unknown in older xfs, which creates the following errors:
XFS (nvme0n1): Filesystem cannot be safely mounted by this kernel.
XFS (nvme0n1): Superblock has unknown read-only compatible features (0x8) enabled.

Use fixed xfsprogs version 5.12.0-r0 from apline:3.14 to avoid this issue. newer implementations will not have these features enabled, and once mountutils fixes the incompatibility, we can drop this.

Summary by CodeRabbit

  • Chores
    • Updated package installation command to improve reliability by specifying a repository URL.
    • Explicitly defined versions for xfsprogs and xfsprogs-extra to ensure compatibility and prevent issues with automatic updates.

@husam-lb husam-lb requested a review from rahman-lb August 12, 2024 12:34
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 12, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent changes focus on enhancing the reliability and consistency of package installations in the deployment process. By specifying a particular repository for Alpine Linux version 3.14 and explicitly defining versions for certain packages, the updates aim to improve version control and reduce potential compatibility issues during deployment.

Changes

Files Change Summary
deploy/Dockerfile Updated package installation command to specify a repository for Alpine 3.14; defined versions for xfsprogs and xfsprogs-extra as 5.12.0-r0. No other changes were made.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@husam-lb husam-lb requested a review from yogev-lb August 12, 2024 12:34
yogev-lb
yogev-lb requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@yogev-lb yogev-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@husam-lb please provide context for this PR
why is it needed?
why do you use packages from v3.14 when we use v3.19 as base and why do we freeze the version.

need coverlatter for the PR

@husam-lb husam-lb changed the title Docerfile: Fix XFS fs type regression Dockerfile: Fix XFS fs type regression Aug 12, 2024
majst01
majst01 reviewed Aug 12, 2024
View reviewed changes
deploy/Dockerfile Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@husam-lb
Copy link
Collaborator Author

alpine v3.14 repos are the latest to support xfsprogs-5.12.0-r0 which in turn needed to support xfs volumes

@husam-lb husam-lb requested review from majst01 and yogev-lb August 13, 2024 13:38
@majst01
Copy link
Collaborator

majst01 commented Aug 13, 2024

o support xfsprogs-5.12.0-r0

Still do not understand why newer xfsprogs break volume creation, i really cant imagine that they break compatibility.

By any chance, on which kernel version does this happen ?

@husam-lb
Copy link
Collaborator Author

o support xfsprogs-5.12.0-r0

Still do not understand why newer xfsprogs break volume creation, i really cant imagine that they break compatibility.

By any chance, on which kernel version does this happen ?

I think it because of using old kernel
alpine 3.19 has kernel 5.15.0-91-generic

@majst01
Copy link
Collaborator

majst01 commented Aug 13, 2024

o support xfsprogs-5.12.0-r0

Still do not understand why newer xfsprogs break volume creation, i really cant imagine that they break compatibility.
By any chance, on which kernel version does this happen ?

I think it because of using old kernel alpine 3.19 has kernel 5.15.0-91-generic

the container image does not come with a kernel, i was asking which kernel the worker node has where this error occurs ?

@husam-lb
Copy link
Collaborator Author

it's 5.15.0-91-generic

@majst01
Copy link
Collaborator

majst01 commented Aug 13, 2024

it's 5.15.0-91-generic

So you have alpine worker nodes ?

@rahman-lb
Copy link
Collaborator

@majst01 Node host OS is Ubuntu 22.04 but the POD's container image is alpine 3.19.x, but i'm guessing this should be a problem on any setup has this version.

rahman-lb
rahman-lb reviewed Aug 13, 2024
View reviewed changes
deploy/Dockerfile
lsblk \
blkid \
kmod \
$EXTRA_PACKAGES

RUN apk add --no-cache --repository=http://dl-cdn.alpinelinux.org/alpine/v3.14/main \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@husam-lb what has triggered this issue ? and do you know why this is not an issue on the internal lb-csi ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mounting xfs formatted volume was failing
see LBM1-21995.

@majst01
Copy link
Collaborator

majst01 commented Aug 14, 2024

@majst01 Node host OS is Ubuntu 22.04 but the POD's container image is alpine 3.19.x, but i'm guessing this should be a problem on any setup has this version.

The OS in the container is not relevant, the xfs-progs are talking to the host kernel to create the Filesystem. I doubt that there is a incompatibility between certain xfs-progs and a ubuntu kernel

@husam-lb
Copy link
Collaborator Author

Things look better with kernel 6.8.0-36-generic of ubnutu 24.4
I it was ok, I will close this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahman-lb rahman-lb rahman-lb left review comments

@majst01 majst01 Awaiting requested review from majst01

@yogev-lb yogev-lb Awaiting requested review from yogev-lb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@husam-lb @majst01 @rahman-lb @yogev-lb