Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leastrecentlyused - ignore unexisting labels in labelLog #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuval-lb
Copy link

after using eraselabel operation, label is removed from label list. but
"leastrecentlyused" is iterating over the "labelLog" from there, the
label still exist. after reading the erased label, osmosis try to check
the size and throw execption.

this will prevent osmosis from interacting with those labels.

Issue:LBM1-8381

after using eraselabel operation, label is removed from label list. but
"leastrecentlyused" is iterating over the "labelLog" from there, the
label still exist. after reading the erased label, osmosis try to check
the size and throw execption.

this will prevent osmosis from interacting with those labels.

Issue:LBM1-8381
Copy link

@adir-lb adir-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{
_alreadyProcessedLabels.emplace( entry.label );
continue;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuval-lb not necessarily related to the PR - when running least-recently-used command, does it log the removed label in the labels log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants