Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated dataloader arguments in Trainer methods #10325

Merged
merged 6 commits into from
Nov 4, 2021
Merged

Remove deprecated dataloader arguments in Trainer methods #10325

merged 6 commits into from
Nov 4, 2021

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Nov 3, 2021 •
edited by carmocca
Loading

What does this PR do?

See title.
Part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

:)
Make sure you had fun coding 🙃

@awaelchli awaelchli changed the title Resolve #10312 with dataloader_renaming Remove deprecated dataloader arguments in Trainer methods Nov 3, 2021
@awaelchli awaelchli added breaking change Includes a breaking change feature Is an improvement or enhancement labels Nov 3, 2021
@awaelchli awaelchli added this to the v1.6 milestone Nov 3, 2021
carmocca
carmocca approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@carmocca carmocca self-assigned this Nov 3, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2021
@carmocca carmocca enabled auto-merge (squash) November 4, 2021 01:03
@carmocca carmocca merged commit 412f0a4 into Lightning-AI:master Nov 4, 2021
@puhuk puhuk deleted the remove_deprecated branch November 5, 2021 10:23
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@puhuk @carmocca @Raalsky
Remove deprecated dataloader arguments in Trainer methods (Lightning-…
006f3af 
…AI#10325)

Co-authored-by: Carlos Mocholi <[email protected]>
@jorshi jorshi mentioned this pull request Apr 29, 2022
Open
@Forecastlife Forecastlife mentioned this pull request May 26, 2022
Open
@jorshi jorshi mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees

@carmocca carmocca

Labels
breaking change Includes a breaking change feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@puhuk @awaelchli @carmocca @SkafteNicki