-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply torch.compile
in Fabric.setup()
#19280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…g-AI/lightning into feature/rewrap-optimized-module
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…g-AI/lightning into feature/rewrap-optimized-module
for more information, see https://pre-commit.ci
…g-AI/lightning into feature/rewrap-optimized-module
for more information, see https://pre-commit.ci
…g-AI/lightning into feature/rewrap-optimized-module
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
awaelchli
commented
Jan 15, 2024
carmocca
reviewed
Jan 15, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
carmocca
approved these changes
Jan 23, 2024
Borda
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Alternative implementation to #19192
Part of #17250
When you do
today, then you end up with
where StrategyWrapper represents the wrapper applied by the strategy, e.g., FSDP, DDP, DeepSpeedEngine, etc.
With the new feature enabled in this PR, you will now get:
Note how the optimized module gets applied outside the strategy wrapper, but inside the fabric module router.
It is important to have the fabric module outside the optimized module, because it contains only convenience routing and precision management that does not need to be compiled (nor can it be without graph breaks atm). At the same time, the FSDP/DDP specific operations can still be captured properly by torch compile, and how it is intended to be wrapped in PyTorch.
This feature is marked as experimental because we first need to test its application in the wild.
Follow-up work:
📚 Documentation preview 📚: https://pytorch-lightning--19280.org.readthedocs.build/en/19280/
cc @Borda @carmocca @justusschock @awaelchli